Only send relevant info about courses to frontend #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel Preview URL 🚀 : https://planner-c9ke3eq1b-utdnebula.vercel.app |
kamui-fin
previously approved these changes
Oct 30, 2023
kamui-fin
dismissed
their stale review
Pre-requisite warning does not show up in preview now
kamui-fin
suggested changes
Oct 30, 2023
|
Vercel Preview URL 🚀 : https://planner-2dwx3tnfd-utdnebula.vercel.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix issue that currently breaks develop - the size of the response from trpc function that returns info about courses is too big. This commit will change it so the trpc function only returns relevant fields, and there's a separate server-side function that includes pre and coreqs for use by validator.ts