Third attempt to explore CI failures #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add filter.py, define the filter for BillingProjects Modify billingproject_list.html to include the filter form Add BillingProjectFilter to BillingProjectList view.
Add filter to ManageGroupList view Add the FilterSet to managedgroup_list template Add tests
Add filter to WorkspaceList view and WorkspaceListByType view Add filter form on workspace_list template Add tests for WorkspaceList view and WorkspaceListByType view
Add AccountList filter to AccountList, AccountActiveList and AccountInactiveList views Add filter form to account_list template Add tests for AccountList, AccountActiveList and AccountInactiveList views
This custom form uses the crispy_form package's layout objects to manipulate the placement and apperance of forms. In particular, it displays the form fields on a single line, including the submit button, with floating labels. This takes up a smaller footprint and is less intrusive compared to the previous standard way of displaying the form.
Pass in query parameter instead of manually appending to the url
Modify tests to be testing more specific things (exact match, contains match, icontains match, multiple objects). For some views, also check that other objects are excluded when appropriate (eg that inactive accounts do not show up in the active account view filter).
This is the same form that was implemented for BillingProjectListFilter.
Missed this one when I was updating the other templates.
This lets the user customize the filterset_class used in the AccountList view. (Example: a project using this app wants to allow people to search on both the account email and the user name associated with the account.)
Add an AccountAdapterMixin, which sets the adapter attribute of the view class. It also contains reusable methods to get information from the adapter (e.g., the list class and the filterset class). Use this mixin for all of the AccountList views, which uses the list_filterset_class defined by whichever account adapter is set by the project settings file.
Tests fail with any version < 2.3.0.
Mostly this includes setting the PIP_NO_CACHE_DIR environment variable. I'm not sure why it was working in the other branch, or if it will definitely fix it here.
The previous commit used the working CI file, but I forgot to add the corresponding tox file. Hopefully this works.
Codecov Report
@@ Coverage Diff @@
## main #407 +/- ##
========================================
Coverage 99.82% 99.82%
========================================
Files 119 121 +2
Lines 22335 22795 +460
========================================
+ Hits 22295 22755 +460
Misses 40 40
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Didn't seem to help.
This seems to be breaking the CI, so try removing it.
No longer used if testing only on 10.4
I would be surprised if this made a difference
|
Finally figured out a potential solution; added separately to the search PR #393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.