Modify autocomplete for ManagedGroups #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ManagedGroupAutocomplete method did not return groups that were not managed by the app, which means that we cannot add groups not managed by the app to other groups or share a workspace with a group not managed by the app. This is not the intended behavior. Modify the autocomplete method to have a forwarded value that specifies whether to return only groups that are managed by the app.
This means that a user can only select a group that is managed by the app as the parent group for a GroupGroupMembership or the group for the GroupAccountMembership.
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 121 121
Lines 22872 22882 +10
=======================================
+ Hits 22833 22843 +10
Misses 39 39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows child groups to be added as members of another group, and also allows workspaces to be shared with them.
Closes #399