Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow WorkspaceData objects to have a second fk to Workspace #435

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

amstilp
Copy link
Contributor

@amstilp amstilp commented Nov 7, 2023

Closes #434

The bug occurs when a workspace data object has a second foreign
key to workspace. The inlineformset_factory method does not know
which fk it should be referring to. Add a custom workspace data
model with this foreign key. Add an adapter and a form. Add a test
for WorkspaceCreate where the exception is raised.
Fix the bug by adding fk_name to the inlineformset_factory calls
made by WorkspaceCreate and WorkspaceImport.
@amstilp amstilp marked this pull request as ready for review November 7, 2023 23:26
@amstilp amstilp merged commit e475e2f into main Nov 7, 2023
18 checks passed
@amstilp amstilp deleted the bugfix/434-workspace-data-second-fk branch November 7, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create a workspace data type with a (second) fk to Workspace
1 participant