Implement interrupt-driven UART transfers #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navtajh04
requested changes
Feb 16, 2024
twilkhoo
force-pushed
the
tejas/enable-async-uart-transfers
branch
from
9c04f4f to
a465463
Compare
Yarik-Popov
requested changes
Mar 1, 2024
| @@ -391,7 +391,8 @@ static obc_error_code_t handleSendingConnState(void) { | |||
| } | |||
| obc_error_code_t errCode; | |||
| #if COMMS_PHY == COMMS_PHY_UART | |||
| RETURN_IF_ERROR_CODE(sciSendBytes(connCmdPkt.data, (uint32_t)connCmdPkt.length, portMAX_DELAY, UART_PRINT_REG)); | |||
| RETURN_IF_ERROR_CODE( | |||
| sciSendBytes(connCmdPkt.data, (uint32_t)connCmdPkt.length, portMAX_DELAY, pdMS_TO_TICKS(100), UART_PRINT_REG)); | |||
There was a problem hiding this comment.
Add macro for pdMS_TO_TICKS(100) and change it everywhere this value is used. What does this represent? Why is it 100?
There was a problem hiding this comment.
Done, changed to 1000ms to be more generous. It's just a value that should be enough for the transmit, and I'm now using 1000 to keep it in line with the timeout for reading the first byte (sciReadBytes in same file).
Navtajh04
requested changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://www.notion.so/uworbital/Implement-interrupt-driven-UART-transfers-210f61abbeed4549bacdadde775f3bee?pvs=4
Make transfers from the RM46 to the IMU async (using UART).
New Changes
sciSendBytesinobc_sci_io.sciReadBytes.Testing
Outstanding Changes