CC1120 Temprature Sensor #286
Draft
+3,352
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And implemented helper function to get readings for a group (assuming proper settings in adc.c file)
And implemented helper function to get readings for a group (assuming proper settings in adc.c file)
…BC-firmware into kashifb/adc-helper-functions
- adcGetSingleData gets group data, and then finds and returns data for single channel - Added macros for adc resolution mode and max group size (necessary for adcGetData since malloc isn't allowed) - Added another error code, if channel ID isn't found when adcGetSingleData is called - Streamlined adcGetSingleData and adcGetGroupData to use helper function adcGetGroupReadings. They only differ in how they store/convert the digital values to analog
-adcGroupSize stores the # of channels for each group for each adc module. -This should be updated every time a new channel is added to a group in the ADGxSEL register. Should also be updated when a channel is removed from a group.
Didn't change pinmux, didn't enable ADC2, didn't change any settings for ADC1.
-Fixed some style issues / removed unnecessary code -Abstracted away ADC_base_t and group information by making enums -Made each channel of ADC into constants so users can easily configure channels in other files -Configured channelID setting in HAL which is needed to check if the channel matches the data in adcGetSingleData
hardcoded table in header file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Explain the purpose of the PR here, including references to any existing Notion tasks.
https://uworbital.notion.site/Write-CC1120-temperature-sensor-driver-496d24bb4311426faae72d3d1e640762
Adds the driver for the CC1120 temperature sensor, using the ADC helper functions we have.
Branches off the adc helper functions pr. Once that's merged in, I can amend this branch.
New Changes
Testing
Outstanding Changes