Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: volumes and lifecycle updates #36

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat: volumes and lifecycle updates #36

merged 3 commits into from
Jul 11, 2023

Conversation

waveywaves
Copy link
Member

@waveywaves waveywaves commented Jul 11, 2023

fixes #35

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #36 (d37f41b) into main (c2da179) will decrease coverage by 3.07%.
The diff coverage is 11.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   19.58%   16.51%   -3.07%     
==========================================
  Files           4        4              
  Lines         388      448      +60     
==========================================
- Hits           76       74       -2     
- Misses        308      370      +62     
  Partials        4        4              
Impacted Files Coverage Δ
controllers/uffizzicluster_controller.go 0.00% <0.00%> (ø)
controllers/vcluster.go 100.00% <ø> (ø)
controllers/ingress.go 72.41% <47.82%> (+2.41%) ⬆️
controllers/conditions.go 100.00% <100.00%> (ø)

@waveywaves waveywaves merged commit 07f4bfa into main Jul 11, 2023
@waveywaves waveywaves deleted the volumes-and-labels branch August 22, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersistentVolumeClaims support for virtual clusters
1 participant