Draft letting the vCluster Helm chart manage its own Ingress. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 19.58% 12.54% -7.05%
==========================================
Files 4 4
Lines 388 590 +202
==========================================
- Hits 76 74 -2
- Misses 308 512 +204
Partials 4 4
|
waveywaves
requested changes
Jul 20, 2023
controllers/vcluster.go
Outdated
| @@ -36,6 +36,12 @@ type EnabledBool struct { | |||
| Enabled bool `json:"enabled"` | |||
| } | |||
|
|
|||
| type VClusterIngress struct { | |||
| Enabled bool `json:"enabled"` | |||
There was a problem hiding this comment.
can you add , omitempty for all the values here.
axisofentropy
force-pushed
the
feature/vcluster_ingress_refactor_2023-07
branch
from
bf42307
to
b4dd498
Compare
|
Uffizzi Cluster |
|
this ended up being a hotfix for issue seen last night https://uffizzi-internal.slack.com/archives/CN8MKSAQ5/p1691725574228729 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.