[1110_uffizzi_platform] WIP #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moklidia
reviewed
Aug 14, 2023
lib/uffizzi/shell.rb
Outdated
| @@ -54,6 +55,10 @@ def stdout_pipe? | |||
| $stdout.stat.pipe? | |||
| end | |||
|
|
|||
| def execute(command) | |||
| Open3.capture3(command) | |||
There was a problem hiding this comment.
I'm not sure this will work with a binary
zipofar
force-pushed
the
feature/1110_uffizzi_platform_user-can-install-uffizzi-on-their-k8s-cluster
branch
5 times, most recently
from
796986a
to
7104dd8
Compare
moklidia
force-pushed
the
feature/1110_uffizzi_platform_user-can-install-uffizzi-on-their-k8s-cluster
branch
from
7104dd8
to
a932923
Compare
zipofar
force-pushed
the
feature/1110_uffizzi_platform_user-can-install-uffizzi-on-their-k8s-cluster
branch
6 times, most recently
from
4b21116
to
aaaa8d9
Compare
moklidia
reviewed
Sep 6, 2023
|
|
||
| def run_installation | ||
| kubectl_exists? | ||
| helm_exists? |
There was a problem hiding this comment.
What if they don't exist? I don't see that the code execution is interrupted after this check.
There was a problem hiding this comment.
execute_command It takes care of that
zipofar
force-pushed
the
feature/1110_uffizzi_platform_user-can-install-uffizzi-on-their-k8s-cluster
branch
from
5590fe0
to
6b53741
Compare
zipofar
force-pushed
the
feature/1110_uffizzi_platform_user-can-install-uffizzi-on-their-k8s-cluster
branch
from
59cd181
to
2cfc14e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.