Fix/template email (#84)

* update django-core and change to new mail backend

* run tests using pytest

* test for new experiment mail

* fixup! update django-core and change to new mail backend

.github/workflows/django-tests.yml

@@ -30,9 +30,10 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           pip install -r requirements.txt
+          pip install -r requirements.dev.txt
       - name: Compile messages
         run: |
           python manage.py compilemessages
       - name: Run Tests
         run: |
-          python manage.py test
+          pytest

experiments/tests/test_email.py

@@ -0,0 +1,13 @@
+from main.models import User
+from ..models import Experiment
+from ..utils import send_new_experiment_mail
+
+
+def test_new_experiment_mail(db, rf, mailoutbox):
+    experiment = Experiment.objects.create(title='CoolExp')
+    user = User.objects.create(first_name='John', last_name='Doe')
+    request = rf.get('/')
+    send_new_experiment_mail(experiment, user, request)
+    assert len(mailoutbox) == 1
+    assert 'CoolExp' in mailoutbox[0].body
+    assert 'John Doe' in mailoutbox[0].body

experiments/tests.py → experiments/tests/test_experiments.py

@@ -9,7 +9,7 @@
 import uuid
 
 # Create your tests here.
-from .models import Experiment, ParticipantSession, TargetGroup, DataPoint
+from ..models import Experiment, ParticipantSession, TargetGroup, DataPoint
 
 
 class ParticipantSessionSubjectIdTests(TestCase):

experiments/utils/mails.py

@@ -3,7 +3,7 @@
 
 from experiments.models import Experiment
 from main.models import User
-from cdh.core.mail import send_template_email
+from cdh.mail.utils import send_template_email
 
 
 def send_new_experiment_mail(experiment: Experiment, user: User, request) -> \

pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+DJANGO_SETTINGS_MODULE = webapp_datastore.settings

requirements.dev.txt

@@ -0,0 +1,2 @@
+pytest
+pytest-django

requirements.in

@@ -1,5 +1,5 @@
 Django>=4.2,<5
-cdh-django-core[all] @ git+https://github.com/CentreForDigitalHumanities/django-shared-core.git@v3.1.0
+cdh-django-core[all] @ git+https://github.com/CentreForDigitalHumanities/django-shared-core.git@v3.2.0
 django-axes
 django-auth-ldap
 django-cors-headers

requirements.txt

@@ -19,7 +19,7 @@ bpython==0.24
     # via cdh-django-core
 build==1.2.1
     # via pip-tools
-cdh-django-core[all,core,federated-auth,files,recommended,rest,vue] @ git+https://github.com/CentreForDigitalHumanities/django-shared-core.git@v3.1.0
+cdh-django-core[all,core,federated-auth,files,mail,recommended,rest,vue] @ git+https://github.com/CentreForDigitalHumanities/django-shared-core.git@v3.2.0
     # via -r requirements.in
 certifi==2024.7.4
     # via requests
@@ -79,7 +79,9 @@ django-debug-toolbar==4.4.6
 django-extensions==3.2.3
     # via cdh-django-core
 django-filter==24.2
-    # via -r requirements.in
+    # via
+    #   -r requirements.in
+    #   cdh-django-core
 django-impersonate==1.9.4
     # via
     #   -r requirements.in

webapp_datastore/settings.py

@@ -74,6 +74,7 @@
     'experiments',
     'cdh.core',
     'cdh.vue',
+    'cdh.mail',
 
     'impersonate',