[ROBO-4338] Add Owner field to BookmarkInfo #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihainradu
reviewed
Dec 18, 2024
src/Directory.Build.props
Outdated
| @@ -1,6 +1,6 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <Version>6.0.0</Version> | |||
|
pls add tests with persistIdle arg.GetBookmarks, and directly accessing workflowapplication.GetBookmarks |
|
maybe its worth to modify ann make sure we receive BookmarkInfo for all bookmarks ... even emptynames... if that seems problematc we could add a new method... the purpose here would be to also detect bookmarks like the ones from Delay activity |
mihainradu
reviewed
Jan 13, 2025
| @@ -39,6 +41,12 @@ public BookmarkScopeInfo ScopeInfo | |||
| private set => _scopeInfo = value; | |||
| } | |||
|
|
|||
| public Activity Owner | |||
There was a problem hiding this comment.
Add tests this is set ok... also after a suspension
daniel-stanciu
requested review from
aoltean16 and
gabriela-lungu-uip
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.