-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVE updates for AS 22.10.7.1 #267
base: stable
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please double-check the versions in the file, maybe they can be made more consistent? Also, please double-check which branch this needs to be merged into.
"description": "Backend server for the Computer Vision solution that detects User Interface Elements from a provided Application screenshot", | ||
"displayName": "ComputerVision", | ||
"gpu": 1, | ||
"inputDescription": "Please use the Computer Vision Activities included in the UIAutomation package. For more information please visit the official documentation.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: Please include a link to the official documentation, you can see the messages used in the latest metadata files (for 23.10 for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
"minAIFabricVersion": "22.10", | ||
"languageVersion": 3, | ||
"version": 4, | ||
"customVersion": "22.10.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this 22.10.1
but above there is Release v2022.10.10
? Can these versions match without any negative side-effects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right. I've changed to 22.10.10, since the same behaviour was also in 23.4/23.10.
@irinel-birsan-uipath can you please confirm that this is the correct way to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we set it like minAIFabricVersion": "22.10",
Anyway, this is onlt informative, there is no check done on AIC side :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, don't forget about the branch comment above.
"tenantName": "UiPath", | ||
"minAIFabricVersion": "22.10", | ||
"languageVersion": 3, | ||
"version": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set version 9 here. Has to match with the number present in the filename to ensure that is different to other existing versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge to testing branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but only after addressing Irinel's comment
Linked with SF repo's PR: https://github.com/UiPath/service-fabric-packaging/pull/15387