Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize MinecraftAccount::data.minecraftProfile.id #310

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

stucq
Copy link

@stucq stucq commented Oct 21, 2023

this is very minor but it makes running 1.20.2 possible and therefore fixes #303, #308, and #309. in spite of this it does require all profiles to be deleted and recreated (not just refreshed)

@stucq
Copy link
Author

stucq commented Oct 23, 2023

as an aside this is a little broken so consider it a temporary workaround at best

@0x24authorname
Copy link

I compiled the PR and can confirm it fixes the problem

@yarik303
Copy link

i think ultimmc creator has abondend the project or smth

@stucq
Copy link
Author

stucq commented Oct 29, 2023

I compiled the PR and can confirm it fixes the problem

it kind of does since it defines a UUID but it has its issues that i'll work out Later(tm)

@DartPower
Copy link

DartPower commented Oct 31, 2023

Confirmed, works.
But need to re-add (local) account.

Who can't wait, can use my build with stucq's fix.
https://github.com/dptmc/Launcher

@Neptune650 Neptune650 merged commit be89b84 into UltimMC:develop Nov 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash (IllegalArgumentException: Invalid UUID string: "")
5 participants