Small fix for IPV6 only + DDNS Server #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 127.0.0.1 to accomodate people who want to use the -Djava.net.preferIPv6Addresses=true Java argument to play on IPV6 in priority because localhost defaults to ::1 in IPV6 mode and crashes the game on launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
My ISP only lets me use IPV6 for my server with my friends and i wanted to setup a DDNS hostname so i can update the IPV6 address seamlessly for my friends, but since the DDNS is always both an IPV4 and an IPV6 record and never IPV6 only i have to use the -Djava.net.preferIPv6Addresses=true Java argument since Minecraft always defaults to the IPV4 address (which is blocked) without it.
But then the Launcher doesn't work because of the use of localhost (that defaults to ::1 in IPV6) instead of 127.0.0.1 in the
launcher/minecraft/auth/providers/LocalAuthProvider.h used for the authlib injector's authentication server.
Fixed the two line of code and rebuilt the project to test and now it works perfectly, hope this will end up in an update!
Thank you.