TranslateTool.py update setter and getter to allow for Y axis flip to show expected values in UI for Y #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a direction variable that changes to -1 if the y axis if flipped in the preferences.
HellAholic
changed the title
rburema
approved these changes
Dec 11, 2024
|
I'm catching up on my reviews. It's been about 3 weeks now and I haven't had any problems with this at all. Same with the changes to the Rotation Tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a direction variable that changes to -1 if the y axis if flipped in the preferences.
This will put the values shown in the UI in line with the direction of the tool handle flip (Y+ is in direction that the toolhandle points to)
Ultimaker/Cura#20006