NP-346 add updates to emsdk recipe and fix for nodejs recipe #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also trigger conan-package workflow on NP-* branches Contribute to NP-346
Added Emsdk version 3.1.65 with corresponding source details in conandata.yml and config.yml. Updated Node.js to version 20.16.0 in emsdk's build requirements and ensured TypeScript installation using npm. Enhanced Node.js recipe by appending new paths to build and environment info. Contributes to NP-346
Contribute to NP-346
Contribute to NP-346
Modified the npm install command and run from the emscripten directory. This should install all basic node_modules such as typescript etc. Contribute to NP-346
Need to apply a patch to the version which isn't released yet Contribute to NP-346
Add patch to correct column number comparison typo in lexy. Update configuration to include the new patch and amend Conan recipe for patch handling. Clean up outdated version entries. Contribute to NP-346
rburema
approved these changes
Oct 16, 2024
rburema
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCI doens't have the newer Emsdk version yet. We need this for the
std::optionalbinding and better generated TypeScript files.Also added a custom foonathan-lexy recipe with a fix that isn't released yet. Because the newer Emsdk uses a higher Clang version we're suddenly compiling that function with
constexprthis pathces the recipe.The recipes contain some quick specific hack and are not CCI worthy. I will open up an issue at the CCI to upgrade Emsdk and fix nodejs later this sprint.
Tip
Don't review the whole recipe, it is copied pasted from CCI https://github.com/conan-io/conan-center-index/ just focus on the changes that I needed to make, in the GH workflows and the actual changes to the recipe are in these commits: