CURA-10951_gh_build_curapackage #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modernized the recipe Contributes to CURA-10475
Updated Conanfile's build configurations according to the updated build setup. 'can_run' is used in place of 'cross_building' to improve the reliability of executing tests across different platforms. Added also a method to set the version of the package, if it isn't specified during the build process. Adjusted file copy operations to use wildcard matching rather than explicit file names for better maintainability. It can help to make sure that all the associated files get copied accurately and efficiently. Implemented cleaner file paths notation across the code for better code readability and consistency. Also, simplified the logic by removing redundant conditional statements that may have caused unhandled exceptions previously and potential bugs in the future. contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
contributes to CURA-10951
3 tasks
rburema
approved these changes
Sep 8, 2023
|
|
||
| required_conan_version = ">=1.52.0" | ||
| required_conan_version = ">=1.56.0" |
There was a problem hiding this comment.
Same here as pynest (1.58?) again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernized and make use of the new sipbuildtool and pyprojecttoolchain See: Ultimaker/conan-ultimaker-index#8
Merged to main because this is also a problem there, just not visible because of the caching on the runners