Cura 11365 fix msvc template fail #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now a sort of hybrid approach between compile and run time solutions. CURA-11365
part of CURA-11365
A big oversight. Also turns out that it still wouldn't compile in MSVC if I did this, but fortunately if the lists are focussed on consolidating the 'easy' and 'hard' ones together it works (since the easy ones will compile, and there aren't enough hard ones to justify splitting them up further). part of CURA-11365
Apparently it can't be constexpr on that compiler. part of CURA-11365
done as part of CURA-11365
# Conflicts: # conanfile.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.