Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MakerBot plugin #5
MakerBot plugin #5
Changes from 81 commits
df9b0b5
03b4512
0a546e7
4a338f1
cc1eba9
d9a9f28
3e43412
a8e0443
98e0afd
2d9dc21
01c2c33
1f7a92a
d021414
8d36970
15eb0de
94eb3f1
2ddc6c4
3681de5
13dda18
6ebc114
2e8244e
93a2660
19ab560
446baef
04b9cc6
8dc6295
8d1307a
4a0aaef
d51d1dc
574de0e
55e4da0
394c803
71d55e2
e1f75c4
2dc556a
4e93fde
e9989f7
590d833
758571c
9113cb6
9852b72
8efce15
2ac9973
01f73f3
ad56e31
b4444b6
5838f06
ec1b28f
39291fe
235b548
00067e2
d6eeab6
93827ed
5b2c9b1
809f42e
16e6cd7
47874f4
9dc5c92
158f75c
2197857
b2e8a6e
6afeaea
8e057bd
01a5f9a
3070271
3711f75
3c52e38
12df764
a9c9136
84c77ab
1c32f66
a8328c0
079c573
8b0921a
01648f8
d7182d8
e70fe1d
45001ab
1ff1164
f73ad27
048b151
ed12e00
3c9e886
a830455
76c942c
99b1842
480a555
3f55bf0
8ddd06f
d755576
46917cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macro
DULCIFICUM_VERSION
used to declare a constant; consider using aconstexpr
constantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid case style for function
GCode2Miracle_JTP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How are errors/warnings reported ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not use auto when the type is not explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be splitted a bit for easier readability ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don;t really like the formatting here (caused by the auto-formatter) but I do think ranges are very readable
I think this is partitioned/split into readable chunks way more then a for loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When written like that, yeah it feels much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍