Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span diagrams #1007

Merged
merged 41 commits into from
Jan 28, 2024
Merged

Span diagrams #1007

merged 41 commits into from
Jan 28, 2024

Conversation

EgbertRijke
Copy link
Collaborator

@EgbertRijke EgbertRijke commented Jan 22, 2024

This pull request contains the changes from #885 that don't touch synthetic-homotopy-theory or structured-types, except those changes that are necessary to make the library compile.

This PR contains the following changes:

  • Disambigating between spans and span diagrams. The disambiguation is explained in the relevant files.
  • Developing infrastructure for spans and span diagrams, with the goal of making it useful for pushouts.
  • Add extensive informal explanations to all the new files and to relevant existing files.
  • Change is-injective-map-equiv to is-injective-equiv, because I needed the fact that map-equiv is an injective map somewhere.
  • Refactors binary type duality and generalises the handling of universes for some of the components of binary type duality. We note specifically by avoiding a proof by equivalence reasoning, it was a lot easier to get the underlying equivalences to do the expected thing. Proofs by equivalence reasoning are more suitable in proofs where the actual equivalence is of less importance, such as abstract proofs.
  • A note on equivalence reasoning was added to foundation-core.equivalences.lagda.md to record the previous point on the website.
  • During the development of Rebase infrastructure for pushouts to span diagrams #885 I have left a lot of {{#concept }} macros with unattributed Agda fields. The quickest way to clean that up was just to run through all places where the macro was used and see if there are any unattributed fields. So I did that throughout the library. This includes for files that I would otherwise not have touched, because it didn't make sense to break up my workflow just for them.

Thanks for @VojtechStep for the idea of breaking down #885 into smaller pull requests.

@EgbertRijke
Copy link
Collaborator Author

I had to make some minimal changes to files in synthetic-homotopy-theory to make this branch compile.

@EgbertRijke
Copy link
Collaborator Author

I will self-review it before marking it as ready for review, but I think it compiles now.

@EgbertRijke EgbertRijke marked this pull request as ready for review January 23, 2024 09:11
@EgbertRijke
Copy link
Collaborator Author

I have done everything I wanted to do in this pull request, so it is now ready for review.

@EgbertRijke EgbertRijke changed the title Spans foundation Span diagrams Jan 23, 2024
@EgbertRijke
Copy link
Collaborator Author

No rush, I am totally fine again on the other branch

src/foundation-core/equivalences.lagda.md Outdated Show resolved Hide resolved
src/foundation-core/operations-span-diagrams.lagda.md Outdated Show resolved Hide resolved
src/foundation/binary-type-duality.lagda.md Show resolved Hide resolved
src/foundation/binary-type-duality.lagda.md Show resolved Hide resolved
src/foundation/opposite-spans.lagda.md Show resolved Hide resolved
src/foundation/spans.lagda.md Outdated Show resolved Hide resolved
@EgbertRijke
Copy link
Collaborator Author

I think this PR is done now

@fredrik-bakke
Copy link
Collaborator

Great! I can review the changes tonight most likely

Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holy crap, that was a lot of work done really quickly. Nice job!

@EgbertRijke
Copy link
Collaborator Author

Thanks for catching the typos!

@fredrik-bakke fredrik-bakke enabled auto-merge (squash) January 28, 2024 21:45
@fredrik-bakke
Copy link
Collaborator

Merging now 🎉

@fredrik-bakke fredrik-bakke merged commit c8c9f89 into UniMath:master Jan 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants