-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span diagrams #1007
Span diagrams #1007
Conversation
I had to make some minimal changes to files in |
I will self-review it before marking it as ready for review, but I think it compiles now. |
…pes, span diagrams of families of types
I have done everything I wanted to do in this pull request, so it is now ready for review. |
No rush, I am totally fine again on the other branch |
I think this PR is done now |
Great! I can review the changes tonight most likely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy crap, that was a lot of work done really quickly. Nice job!
Thanks for catching the typos! |
Merging now 🎉 |
This pull request contains the changes from #885 that don't touch
synthetic-homotopy-theory
orstructured-types
, except those changes that are necessary to make the library compile.This PR contains the following changes:
is-injective-map-equiv
tois-injective-equiv
, because I needed the fact thatmap-equiv
is an injective map somewhere.abstract
proofs.foundation-core.equivalences.lagda.md
to record the previous point on the website.{{#concept }}
macros with unattributedAgda
fields. The quickest way to clean that up was just to run through all places where the macro was used and see if there are any unattributed fields. So I did that throughout the library. This includes for files that I would otherwise not have touched, because it didn't make sense to break up my workflow just for them.Thanks for @VojtechStep for the idea of breaking down #885 into smaller pull requests.