-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor files about identity types and homotopies #1014
Conversation
…sker with left-whisker-htpy
…right-whisker-htpy
I thought this would be a quicky but I'm encountering a lot of substandard programming while editing the entries about whiskering, so I better put my shoulders under this and do the refactoring well. I'll mark this PR as a draft for now. |
DONE! 🥵 |
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
I have addressed all the comments now. I defer all the future comments to future pull requests |
Also I am happy to share this PR with @fredrik-bakke, for his heroic efforts of reviewing this monster. Thank you! |
Hooray! 🎉 |
The following files were significantly cleaned up:
foundation.path-algebra
The following files were created:
foundation.action-on-higher-identifications-functions
foundation.whiskering-higher-homotopies
foundation.whiskering-identifications
The following other actions were performed:
whisk
withwhisker
throughout the library.htpy-left-whisker
tohtpy-left-whisker
coherence-square-identifications-horizontal-inv
tohorizontal-inv-coherence-square-identifications
coherence-square-identifications-left-paste
toleft-concat-identification-coherence-square-identification
, and variantsap (ap f)
withap² f
throughout the library. I also renamed the variousnat-sq
-entries aboutap²
.path-algebra
tocommuting-squares-of-identifications
.commuting-squares-of-identifications
andpath-algebra
. These separate formalization attempts have been unified.path-algebra
since they were duplicate entries and they were not actually iterated.ap-concat-eq
tomap-coherence-triangle-identifications
, change the order of its arguments to match withcoherence-triangle-identifications
, and move it tocommuting-triangles-of-identifications
.coherence-square-identifications-ap
tomap-coherence-square-identifications
.inv-htpy-left-whisk-inv-htpy
andinv-htpy-right-whisk-inv-htpy
.ap-left-whisk-htpy
toleft-whisker-htpy²
, andap-right-whisk-htpy
toright-whisker-htpy²
and move them towhiskering-higher-homotopies
.refl-htpy
is a unit element on the homotopy side for whiskering. Instead, it is an absorbing element.