-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename (co)prod
to (co)product
#1017
Conversation
I added a new label "improve naming" because this PR is a quick global search-and-replace that improves our naming. I thought such a label would be more descriptive than "refactoring", because refactoring suggests that you actually factor out steps or clean up to make the code simpler. I'd be happy to put the label back if you think it is more fitting. BTW I am a bit afraid of quick search-and-replace changes since they are (1) so quick to make but (2) easily jinx other people's work. But I think this one is not actually causing so much trouble. |
There was one naming conflict that came up when making this refactoring. Namely,
I consider this PR ready for review again. I can take a quick look over it first during my layover if you prefer, as this is a quick search-and-replace job as you suggested. |
(This also suggests that we may want to change our naming scheme for category theory modules as well. Something I suggest we have a look at when we start doing wild category theory soon.) |
Are you sure that it won't be confusing if |
Good point! |
We will have to disambiguate that special case somehow. Otherwise, do you disagree it is a solid scheme? |
If it's ok with you I will wait with merging this PR until #1014 is merged, because I don't look forward to hours of resolving merge conflicts whereas a much quicker solution would be that you just do your search-and-replace again if there are any problems. |
Sure thing! |
The scheme with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look at about 50 of the files. Looks good to merge to me
No description provided.