Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate definitions #1022

Merged
merged 24 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d444e6c
deduplicate `finite-group-theory`
fredrik-bakke Feb 6, 2024
73a0bc2
deduplicate `is-separated`
fredrik-bakke Feb 6, 2024
cd17eb9
rename `reflection.group-solver.Fin` to `Inductive-Fin`
fredrik-bakke Feb 6, 2024
00d6f51
fix naming conflicts `reflection`
fredrik-bakke Feb 6, 2024
707d664
concatenation*
fredrik-bakke Feb 6, 2024
1a98d1f
cube
fredrik-bakke Feb 6, 2024
d5458f0
open import everything public
fredrik-bakke Feb 6, 2024
0101b2e
fix `compute`-names `finite-algebra`
fredrik-bakke Feb 6, 2024
10556c1
fix constructor naming `reflection.terms`
fredrik-bakke Feb 7, 2024
c0f01b6
whoos `absurd-Clause-Agda`
fredrik-bakke Feb 7, 2024
61f574b
fix constructor naming `reflection.definitions`
fredrik-bakke Feb 7, 2024
0e50db6
fix constructor naming `reflection.arguments`
fredrik-bakke Feb 7, 2024
4ab38b5
improve names `reflection.type-checking-monad`
fredrik-bakke Feb 7, 2024
bc3088f
improve names `reflection.abstractions`
fredrik-bakke Feb 7, 2024
7f20b58
improve names `reflection.fixity`
fredrik-bakke Feb 7, 2024
8f92d73
improve names `reflection.literals`
fredrik-bakke Feb 7, 2024
bf754fb
improve names `reflection.metavariables`
fredrik-bakke Feb 7, 2024
9526b10
`Expr` -> `Expression`
fredrik-bakke Feb 7, 2024
beefb6c
wrap line
fredrik-bakke Feb 7, 2024
1040424
remove `∀` in `group-solver`
fredrik-bakke Feb 7, 2024
c15c769
wrap a line `group-solver`
fredrik-bakke Feb 7, 2024
d06cee2
remove `is-finite-Ab`
fredrik-bakke Feb 7, 2024
e39e15c
Update src/finite-group-theory/finite-groups.lagda.md
fredrik-bakke Feb 7, 2024
383bf0d
review
fredrik-bakke Feb 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ src/everything.lagda.md: agdaFiles
| cut -c 5- \
| cut -f1 -d'.' \
| sed 's/\//\./g' \
| awk 'BEGIN { FS = "."; OFS = "."; lastdir = "" } { if ($$1 != lastdir) { print ""; lastdir = $$1 } print "open import " $$0 }' \
| awk 'BEGIN { FS = "."; OFS = "."; lastdir = "" } { if ($$1 != lastdir) { print ""; lastdir = $$1 } print "open import " $$0 " public"}' \
>> $@ ;\
echo "\`\`\`" >> $@ ;

Expand Down
5 changes: 0 additions & 5 deletions src/finite-algebra.lagda.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,8 @@ module finite-algebra where
open import finite-algebra.commutative-finite-rings public
open import finite-algebra.dependent-products-commutative-finite-rings public
open import finite-algebra.dependent-products-finite-rings public
open import finite-algebra.finite-abelian-groups public
open import finite-algebra.finite-commutative-monoids public
open import finite-algebra.finite-fields public
open import finite-algebra.finite-groups public
open import finite-algebra.finite-monoids public
open import finite-algebra.finite-rings public
open import finite-algebra.finite-semigroups public
open import finite-algebra.homomorphisms-commutative-finite-rings public
open import finite-algebra.homomorphisms-finite-rings public
open import finite-algebra.products-commutative-finite-rings public
Expand Down
12 changes: 6 additions & 6 deletions src/finite-algebra/commutative-finite-rings.lagda.md
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,7 @@ module _
preserves-concat-add-list-Ring-𝔽 finite-ring-Commutative-Ring-𝔽
```

### Equip a finite type with a structure of commutative finite ring
### Equipping a finite type with the structure of a commutative finite ring

```agda
module _
Expand All @@ -603,14 +603,14 @@ module _
UU l1
structure-commutative-ring-𝔽 =
Σ ( structure-ring-𝔽 X)
( λ r → is-commutative-Ring-𝔽 (compute-structure-ring-𝔽 X r))
( λ r → is-commutative-Ring-𝔽 (finite-ring-structure-ring-𝔽 X r))

compute-structure-commutative-ring-𝔽 :
finite-commutative-ring-structure-commutative-ring-𝔽 :
structure-commutative-ring-𝔽 →
Commutative-Ring-𝔽 l1
pr1 (compute-structure-commutative-ring-𝔽 (r , c)) =
compute-structure-ring-𝔽 X r
pr2 (compute-structure-commutative-ring-𝔽 (r , c)) = c
pr1 (finite-commutative-ring-structure-commutative-ring-𝔽 (r , c)) =
finite-ring-structure-ring-𝔽 X r
pr2 (finite-commutative-ring-structure-commutative-ring-𝔽 (r , c)) = c

is-finite-structure-commutative-ring-𝔽 :
is-finite structure-commutative-ring-𝔽
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,5 +156,5 @@ module _
ring-Π-Ring-𝔽 = Π-Ring (type-𝔽 I) (ring-Ring-𝔽 ∘ A)

Π-Ring-𝔽 : Ring-𝔽 (l1 ⊔ l2)
Π-Ring-𝔽 = compute-ring-𝔽 ring-Π-Ring-𝔽 is-finite-type-Π-Ring-𝔽
Π-Ring-𝔽 = finite-ring-is-finite-Ring ring-Π-Ring-𝔽 is-finite-type-Π-Ring-𝔽
```
217 changes: 0 additions & 217 deletions src/finite-algebra/finite-groups.lagda.md

This file was deleted.

Loading
Loading