Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor modifications to transpositions of identifications along equivalences #1033

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Minor modifications to transpositions of identifications along equivalences #1033

merged 4 commits into from
Feb 20, 2024

Conversation

EgbertRijke
Copy link
Collaborator

No description provided.

@EgbertRijke EgbertRijke changed the title Transposition identifications Minor modifications to transpositions of identifications along equivalences Feb 19, 2024
@fredrik-bakke
Copy link
Collaborator

Did you, similarly to me, give up on trying to factor out separate files for transposing identifications along sections and retractions? 😅

@EgbertRijke
Copy link
Collaborator Author

No, I did not attempt that. Is there any problem with doing that?

@fredrik-bakke
Copy link
Collaborator

No, I did not attempt that. Is there any problem with doing that?

Well, no. It's just a larger job than I think it looks at first glance.

fredrik-bakke
fredrik-bakke approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from my few comments!

@EgbertRijke
Copy link
Collaborator Author

I addressed the comments, except the ones that were about filling in _ because I actually like this use of underscore and I am much more comfortable with this use of _ than with the _ in partially evaluated mixfix operators.

@fredrik-bakke fredrik-bakke merged commit 208023d into UniMath:master Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrik-bakke fredrik-bakke fredrik-bakke approved these changes

Assignees
No one assigned
Labels
foundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgbertRijke @fredrik-bakke