Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase infrastructure for coequalizers to double arrows #1098

Merged
merged 4 commits into from
Apr 6, 2024

Conversation

VojtechStep
Copy link
Collaborator

In anticipation for #885. The proof of the universal property of coequalizers being preserved by equivalences of coforks got a bit unwieldy, but it should become more conceptual once morphisms and equivalences of cocones under spans are integrated (for now they exist only in the other PR).

@VojtechStep VojtechStep force-pushed the feature/double-arrows branch 2 times, most recently from 21e38f2 to 1db9be6 Compare March 26, 2024 14:57
@VojtechStep VojtechStep marked this pull request as ready for review March 26, 2024 15:02
@VojtechStep
Copy link
Collaborator Author

This one is now ready for review - there is some low-hanging fruit for refactoring coequalizers (some names, some more prose, formulating the universal property as a large proposition, ...) which I don't want to get into here

@fredrik-bakke fredrik-bakke changed the title Rebase infrastrucure for coequalizers to double arrows Rebase infrastructure for coequalizers to double arrows Mar 26, 2024
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the rest of my review :)

src/synthetic-homotopy-theory/coforks.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/coforks.lagda.md Outdated Show resolved Hide resolved
@VojtechStep VojtechStep force-pushed the feature/double-arrows branch 2 times, most recently from d56e29c to 58750eb Compare April 6, 2024 13:54
@VojtechStep VojtechStep force-pushed the feature/double-arrows branch from 58750eb to d6e246f Compare April 6, 2024 13:56
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

src/foundation/double-arrows.lagda.md Outdated Show resolved Hide resolved
src/foundation/double-arrows.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/morphisms-coforks.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/morphisms-coforks.lagda.md Outdated Show resolved Hide resolved
@fredrik-bakke
Copy link
Collaborator

This PR looks ready to merge to me! Let me know if you are not done

@VojtechStep VojtechStep merged commit f7b8de0 into UniMath:master Apr 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants