Refactoring types with automorphisms/endomorphisms and descent data for the circle #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/structured-types/equivalences-types-equipped-with-endomorphisms.lagda.md
Outdated
Show resolved
Hide resolved
src/structured-types/mere-equivalences-types-equipped-with-endomorphisms.lagda.md
Outdated
Show resolved
Hide resolved
src/structured-types/morphisms-types-equipped-with-endomorphisms.lagda.md
Show resolved
Hide resolved
src/structured-types/morphisms-types-equipped-with-endomorphisms.lagda.md
Show resolved
Hide resolved
That's fine, but yeah, I'm still working on it. I'll mark it as ready for review later today. This is not meant to be a very large refactoring. All I intend to do is make two parts of the library talk to each other. |
VojtechStep
reviewed
Oct 4, 2023
|
This one is ready for review. Note that this PR does not refactor everything I possibly could refactor, because I don't want to refactor everything I could possibly refactor. The purpose of this PR is just to make the structured-types part of the library work well with the descent files for the circle. I'll be happy to make small stylistic changes and quick fixes. |
fredrik-bakke
approved these changes
Oct 4, 2023
src/structured-types/equivalences-types-equipped-with-automorphisms.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/morphisms-descent-data-circle.lagda.md
Outdated
Show resolved
Hide resolved
VojtechStep
reviewed
Oct 5, 2023
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/dependent-descent-circle.lagda.md
Outdated
Show resolved
Hide resolved
…hisms.lagda.md Co-authored-by: Fredrik Bakke <[email protected]>
…omorphisms.lagda.md Co-authored-by: Fredrik Bakke <[email protected]>
…hisms.lagda.md Co-authored-by: Fredrik Bakke <[email protected]>
Co-authored-by: Fredrik Bakke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this refactoring PR we eliminate some duplicate work and define a better integration for descent data of the circle, cyclic types, and types with automorphisms and endomorphisms.