-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Agda 2.6.4 #814
Update to Agda 2.6.4 #814
Conversation
It seems the new version is not yet available from the required resources, so this PR will have to sit in the meantime. |
I was just gonna say, it is not on |
A thought: with the new |
If you're as eager as me, you can download the cask for 2.6.4 here and try* install from your local file using brew install --build-from-source agda.rb |
Also, before this is merged, the # Unstable is needed for Agda 2.6.3, latest stable 22.11 only has 2.6.2.2 However, I don't see how to update the file to use 2.6.4 |
The file that needs updating is |
I'm not that adventurous with my agda-installation:) I've installed it with brew, and it updates whenever updates come through brew. I found that this setup works much better for me than if I fiddle with the installation myself. So I'll wait patiently until it is on brew:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabling the --level-universe
flag will require some more deliberation before it can be implemented.
It looks like there are other occurrences of '2.6.3', because when I did a global search-replace it found 11 instances. |
Thanks! I'll look into it |
I'm also quite puzzled why agda 2.6.4 is still unknown to our CI. Did we set up something incorrectly, or is it really taking this long for the new release version to be recognized? |
Maybe I set up something wrong in this PR. This would make sense given the discrepancy you previously pointed out. |
Give me a little bit of time and I can investigate it |
Still seems like 2.6.4 isn't available for the CI tooling. I don't know much beyond that though. Also, Agda 2.6.4 is not available for Nix either, and I think we should wait to merge this PR until it is. |
I agree with you, it doesn't make much sense to merge this PR until 264 is available for the CI. |
@fredrik-bakke if you bump the |
Nix already has 2.6.4 (though it doesn't show on the website, not sure why) |
Oh. Well then. That leaves the Arch situation, how can we track that? |
By the way, do you know if the two "required checks" for 2.6.3 will update when the branch is merged? |
We can keep checking the pacman page, or we can ask @maybemabeline to ping us once she gets the update.
I'd think so - usually the "expected" checks are taken from the master/target branch, so that you don't accidentally/maliciously remove previously required checks; so once this PR gets merged, the default expected check would change from {macOS,ubuntu}-2.6.3 to {macOS,ubuntu}-2.6.4. |
Good point, thanks! |
Oh and just because Agda 2.6.4 is available from nixpkgs doesn't mean that we're pulling it, we need to update the |
I kept the mdbook crates on the same version by pinning the checkout of nixpkgs we were using previously as `nixpkgs-mdbook`
Bump nixpkgs for Agda 2.6.4
As mentioned on Discord, Agda 2.6.4 is available on Arch, so there should be nothing blocking this PR any longer. |
I think this is wrong, actually - apparently "required checks" isn't an automatic thing, it's a branch protection rule that can be configured via the GitHub UI in repository settings (Settings > Branches > edit protection rule "Require status checks to pass before merging"), but I don't have rights to access that part of the repository settings. |
Me neither. We will have to wait until @EgbertRijke sees this. |
Co-authored-by: Egbert Rijke <[email protected]> Co-authored-by: VojtechStep <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]> Co-authored-by: VojtechStep <[email protected]>
Bumps the Agda version to
2.6.4
and sets the.--level-universe
flag