-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small subcategories #861
Merged
Merged
Small subcategories #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrik-bakke
commented
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
EgbertRijke
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing pull request, containing many very nice additions to the library. Very cool!
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
Co-authored-by: Egbert Rijke <[email protected]>
fredrik-bakke
added a commit
to fredrik-bakke/agda-unimath
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Egbert Rijke <[email protected]>
fredrik-bakke
added a commit
to fredrik-bakke/agda-unimath
that referenced
this pull request
Oct 20, 2023
Co-authored-by: Egbert Rijke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an embarrassing mistake I introduced a couple of days ago where I defined embeddings of categories to only be embeddings on hom-sets instead of equivalences. That is fixed in this PR. Sorry about that 😬
This PR also leaves some future work. Namely, that fully faithful functors reflect isomorphisms, and that subcategories are indeed categories. I don't know when/if I'll take the time to prove those though, so I prefer if this PR is merged before then.