-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal property of smash products #865
Universal property of smash products #865
Conversation
src/structured-types/commuting-squares-of-pointed-maps.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/pushouts-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/pushouts-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/pushouts-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
Good work so far! I'd have to write out what you're trying to do, in order to help you, because it's hard to see just like that from a github pull request:) Maybe I'll come up with something over the weekend, if you haven't figured it out by then. |
In my latest commit I added some accessors for the first and second projections of equalities in Sigma types. Suggestions for better names for these functions are welcome and please let me know if I missed that these were already implemented somewhere else. |
There's some work that still needs to be done with the universal property of the smash product but this pull request is already getting pretty big so I would prefer if this gets merged now and I add the rest in separate pull requests later. |
src/structured-types/commuting-squares-of-pointed-maps.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Fredrik Bakke <[email protected]>
I think removing the brackets doesn't work in the case of pointed maps, because they might not have had the same change of precedence. |
af98726
to
52d7e93
Compare
Oh, that is actually an oversight! You have my permission to add the following line to infix 6 _~∗_ That should fix the problem. |
I'll be happy to merge this once the final comments have been addressed. Great work again! |
One last thing I'd like get feedback on is on the naming of functions that compute what identifications some function makes, of which I have a few. I realized I've rather awfully variously named them |
Thanks for asking! I don't think we have a more specialized naming scheme for this than the general one. Some descriptors that are generally used in the context are |
src/synthetic-homotopy-theory/smash-products-of-pointed-types.lagda.md
Outdated
Show resolved
Hide resolved
Thanks again for the fix, looking forward to your next PR! 😊 |
I added some functions for computing with the universal property of pushouts of pointed types and a function that computes the identifications created by the map from the product to the smash product. I also started working on one of the sides of the universal property, but the last hole ended up as a very complicated dependent identification that I'm not sure how to handle. If anyone wants to look at it, you are welcome to do so :) --------- Co-authored-by: Fredrik Bakke <[email protected]>
I added some functions for computing with the universal property of pushouts of pointed types and a function that computes the identifications created by the map from the product to the smash product.
I also started working on one of the sides of the universal property, but the last hole ended up as a very complicated dependent identification that I'm not sure how to handle. If anyone wants to look at it, you are welcome to do so :)