Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement is-torsorial throughout the library #875

Merged
merged 21 commits into from
Oct 21, 2023
Merged

Implement is-torsorial throughout the library #875

merged 21 commits into from
Oct 21, 2023

Conversation

EgbertRijke
Copy link
Collaborator

This pull requests does three things:

  • Implements is-torsorial throughout the library
  • Refactors is-identity-system
  • Refactors equivalence induction

fredrik-bakke
fredrik-bakke approved these changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must have taken quite a bit of effort to refactor, very good work! And the added explanations make me much more confident in this change of terminology. 💯

@fredrik-bakke
Copy link
Collaborator

Let me know when you're ready to merge

@EgbertRijke
Copy link
Collaborator Author

The website builds on my computer, so it is ready to merge

@fredrik-bakke fredrik-bakke enabled auto-merge (squash) October 21, 2023 19:02
@EgbertRijke
Copy link
Collaborator Author

This must have taken quite a bit of effort to refactor, very good work! And the added explanations make me much more confident in this change of terminology. 💯

Yeah, like 6 hours or perhaps even 8.

@fredrik-bakke
Copy link
Collaborator

That's crazy! I hope you remembered to take a couple of breaks

@EgbertRijke
Copy link
Collaborator Author

Lol, this was my break. I was doing the abelianization thing and then I thought I'd quickly do this as a break:)

@fredrik-bakke fredrik-bakke merged commit 6004b21 into UniMath:master Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrik-bakke fredrik-bakke fredrik-bakke approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgbertRijke @fredrik-bakke