Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Characterizing the fibers of cogap as a pushout of fibers #887

Merged
merged 16 commits into from
Oct 28, 2023
Merged

Characterizing the fibers of cogap as a pushout of fibers #887

merged 16 commits into from
Oct 28, 2023

Conversation

tomdjong
Copy link
Contributor

No description provided.

@tomdjong tomdjong changed the title Characterizating the fibers of cogap map as pushout of fibers Characterizing the fibers of cogap map as pushout of fibers Oct 27, 2023
@tomdjong tomdjong changed the title Characterizing the fibers of cogap map as pushout of fibers Characterizing the fibers of cogap as a pushout of fibers Oct 27, 2023
fredrik-bakke
fredrik-bakke approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@fredrik-bakke fredrik-bakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, Tom! This looks very good to me, I just have some comments on formatting.

src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
VojtechStep
VojtechStep reviewed Oct 28, 2023
View reviewed changes
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
src/synthetic-homotopy-theory/pushouts.lagda.md Outdated Show resolved Hide resolved
@tomdjong
Copy link
Contributor Author

Thank you both for the comments and suggestions, @VojtechStep @fredrik-bakke!
In particular, thanks for the explanations, Fredrik :)

VojtechStep
VojtechStep approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@VojtechStep VojtechStep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I have nothing to add. Thanks for the contribution!

@fredrik-bakke
Copy link
Collaborator

Excellent! I will merge this now :) Thanks again for the contribution and collaboration 😄

@fredrik-bakke fredrik-bakke merged commit fb9fab0 into UniMath:master Oct 28, 2023
4 checks passed
@tomdjong
Copy link
Contributor Author

Thank you!

@tomdjong tomdjong deleted the fibers-of-cogap-map branch October 30, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrik-bakke fredrik-bakke fredrik-bakke approved these changes

@VojtechStep VojtechStep VojtechStep approved these changes

Assignees
No one assigned
Labels
synthetic-homotopy-theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomdjong @fredrik-bakke @VojtechStep