Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indiscrete precategories #896

Merged
merged 133 commits into from
Nov 24, 2023

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Oct 31, 2023

This is a small(er) one. It

  • Defines indiscrete precategories and proves some basic facts
  • Defines the terminal category as an indiscrete precategory and proves some basic facts
  • Defines the initial category as an indiscrete precategory and proves some basic facts
  • Defines the corollaries of the Yoneda lemma when both functors are representable

Depends on #886 and #880.

fredrik-bakke and others added 30 commits October 21, 2023 22:31
This is an experimental attempt to get some sort of uniform treatment of
iterated type families going.

Work in progress, and ideas are very welcome.

---------

Co-authored-by: Fredrik Bakke <[email protected]>
@EgbertRijke
Copy link
Collaborator

Would it be possible to rebase this one, so that I can see what actually changed? Because while it had the appearance that I "just merged" the other to PRs today, I did actually look over them quickly. But these 9000 lines are too much.

@fredrik-bakke
Copy link
Collaborator Author

Done

@fredrik-bakke
Copy link
Collaborator Author

Or, at least, GitHub is telling me there are only 851 lines of additions now

@EgbertRijke
Copy link
Collaborator

Great, thanks!

Copy link
Collaborator

@EgbertRijke EgbertRijke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice pull request! My apologies for letting this linger for so long... I am again reviewing this from the gas station with free wifi:P

I made some suggestions for additional files that I think would be nice to have. Feel free to defer these suggestions to future work. It would be also be good to merge this pull request without the additional files.

src/category-theory/indiscrete-precategories.lagda.md Outdated Show resolved Hide resolved
src/category-theory/indiscrete-precategories.lagda.md Outdated Show resolved Hide resolved

initial-functor-Precategory : functor-Precategory initial-Precategory C
pr1 initial-functor-Precategory ()
pr1 (pr2 initial-functor-Precategory) {()}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I haven't seen that one before;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something here you would want me to change?

src/category-theory/initial-category.lagda.md Show resolved Hide resolved
@EgbertRijke
Copy link
Collaborator

Apparently you didn't get to updating the PR yet, but I'm going to merge it. We can resolve the review suggestions in a next PR.

@EgbertRijke EgbertRijke enabled auto-merge (squash) November 24, 2023 04:05
@EgbertRijke EgbertRijke merged commit 6e35e8f into UniMath:master Nov 24, 2023
4 checks passed
fredrik-bakke added a commit to fredrik-bakke/agda-unimath that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants