Refactor functoriality and various infrastructure for sequential colimits #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
3 times, most recently
from
f6abf0e to
3de6f7a
Compare
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
2 times, most recently
from
d89ca6f to
7b4df83
Compare
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
3 times, most recently
from
58111d4 to
7d65b34
Compare
|
This one is now ready for review |
fredrik-bakke
approved these changes
Dec 22, 2023
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Show resolved
Hide resolved
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
EgbertRijke
reviewed
Dec 29, 2023
src/synthetic-homotopy-theory/cocones-under-sequential-diagrams.lagda.md
Show resolved
Hide resolved
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
from
7d65b34 to
2607f0a
Compare
EgbertRijke
reviewed
Jan 9, 2024
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
EgbertRijke
reviewed
Jan 9, 2024
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
EgbertRijke
reviewed
Jan 9, 2024
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
EgbertRijke
reviewed
Jan 9, 2024
src/synthetic-homotopy-theory/functoriality-sequential-colimits.lagda.md
Outdated
Show resolved
Hide resolved
|
Would it be possible to work towards merging this PR? |
|
Yes, I'll be at my computer in like an hour, and I'll try to address the comments |
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
from
148c592 to
3391983
Compare
|
I rebased on master and addressed most of the suggestions. The last thing left open is my usage of the term "corollary", which I explained, and I'm waiting for a reaction |
src/synthetic-homotopy-theory/cocones-under-sequential-diagrams.lagda.md
Outdated
Show resolved
Hide resolved
It looks like a cocone is enough to infer its diagram, and a (D)UP is enough to infer the cocone to which it applies
VojtechStep
force-pushed
the
refactor/functoriality-sequential-colimits
branch
from
3391983 to
e9d7cce
Compare
|
I'm happy with the changes! I think I'm just gonna go ahead and merge this one |
|
Thank you for this PR Vojta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main contribution is generalizing #919 to statements about general sequential colimits given by cocones with a universal property, and then specializing those to the case of standard sequential colimits.