-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor refactoring surrounding Dedekind reals #983
Conversation
Turns out we have 3 different names for implication at the moment:
This seems a little overkill to me. |
For fun, here's what is-dedekind-cut-Prop : Prop (l1 ⊔ l2)
is-dedekind-cut-Prop =
( exists-Prop ℚ L ∧ exists-Prop ℚ U) ∧
( Π-Prop ℚ
( λ q → iff-Prop (L q) (exists-Prop ℚ (λ r → le-ℚ-Prop q r ∧ L r)))) ∧
( Π-Prop ℚ
( λ r → iff-Prop (U r) (exists-Prop ℚ (λ q → le-ℚ-Prop q r ∧ U q)))) ∧
( ( Π-Prop ℚ (λ q → neg-Prop (L q ∧ U q))) ∧
( Π-Prop ℚ
( λ q → Π-Prop ℚ (λ r → implication-Prop (le-ℚ-Prop q r) (L q ∨ U r))))) Notice that there are many competing conventions going on, which is not good. |
The competing conventions are as follows:
|
I eliminated convention 2 by making |
To be clear, there is quite a bit of refactoring left to do regarding the definition of Dedekind cuts, but I don't have time for that currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Arising from a discussion on the Discord earlier today, here are some mild refactors.
disj
todisjunction
(disambiguates fromdisjoint
)conj
toconjunction
(disambiguates fromconjugation
)_⇒_
notation fortype-implication-Prop
. This is consistent with the already-established_⇔_