Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add declarative skewt plotting #2488

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add declarative skewt plotting #2488

wants to merge 5 commits into from

Conversation

kgoebber
Copy link
Collaborator

Description Of Changes

This PR add the ability to create a SkewT plot through the declarative syntax. In addition to that, I have implemented a function for plotting skewT special lines with labels (based off of code from @DrKimWood, thanks!). There is some slight reorganization of declarative to anticipate some repeated code - we'll see what the checkers say to potentially do more of that.

This is initially a draft PR to allow for comments and evolution on naming and other things within the code.

A few tests have been added, but there could likely be more.

If anyone would like to take this draft forward, please feel free!

Checklist

  • Closes #xxxx
  • Tests added
  • Fully documented

@dopplershift dopplershift added Type: Feature New functionality Area: Plots Pertains to producing plots labels May 20, 2022
@kgoebber kgoebber force-pushed the declare_skewt branch 2 times, most recently from 36cf18d to 1c88b18 Compare July 21, 2022 16:34
@kgoebber kgoebber marked this pull request as ready for review July 21, 2022 16:34
@kgoebber kgoebber requested a review from a team as a code owner July 21, 2022 16:34
@kgoebber kgoebber requested review from dopplershift and removed request for a team July 21, 2022 16:34
@dopplershift
Copy link
Member

Not sure why exactly this is failing with our minimum versions. Also, this is now conflicting with declarative.py.

@kgoebber
Copy link
Collaborator Author

Yeah, I don't know why its conflicting with minimum, other than there was some difference with Matplotlib 3.3.0 compared to current versions?

@kgoebber
Copy link
Collaborator Author

kgoebber commented Sep 17, 2022 •
edited
Loading

Yes, I had conflicts with the latest rebase due to pulling out some elements to a PanelTraits class since this PR introduces a new Panel type (SkewPanel along with our long standing MapPanel). There were also some other conflicts with the addition of ArrowPlot. Now that the additional titles are merged, I'll rebase on the current main and see if we can get a cleaner merge.

@kgoebber
Copy link
Collaborator Author

I've come across a small package called matplotlib-label-lines that might be a better solution than what is implemented in the PR. Thoughts on using this or adopting some of their code?

@dopplershift dopplershift added this to the September 2023 milestone Aug 30, 2023
@dopplershift dopplershift mentioned this pull request Nov 9, 2023
Open
@kgoebber
Copy link
Collaborator Author

This PR is now all rebased, no real conflicts, couple of small outdated items left over from the original PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift Awaiting requested review from dopplershift dopplershift is a code owner automatically assigned from Unidata/metpy-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area: Plots Pertains to producing plots Type: Feature New functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kgoebber @dopplershift