Fix q_vector units w/ default static stability #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Type: Bug
There unfortunately is, as Holton (2013) does not include the 1/sigma factor, which was unfortunately the (undocumented except in the issue tracker) intended behavior when it was originally written. Though, I'm not sure if that difference of definition is enough to stick with the old behavior or not! EDIT: See #3689 (comment) for a much better discussion on this. Based on this insight, I would concur that the best move is likely moving away from the prior behavior and do something like this PR. |
dopplershift
had a problem deploying
to
CodeCov
GitHub Actions
Failure
dopplershift
force-pushed
the
qvector-units
branch
from
e1e3ae8 to
19065c5
Compare
dopplershift
had a problem deploying
to
CodeCov
GitHub Actions
Failure
jthielen
reviewed
Nov 14, 2024
dopplershift
force-pushed
the
qvector-units
branch
from
19065c5 to
48b6dd5
Compare
dopplershift
force-pushed
the
qvector-units
branch
from
48b6dd5 to
7992503
Compare
Clarify the optional role of static_stability and how that maps to various GEMPAK calculations. Also ensure that values for `static_stability` are properly checked for dimensionality.
Helps make clear that this is an option for this calculation. Addresses part of Unidata#3689.
dopplershift
force-pushed
the
qvector-units
branch
from
7992503 to
909449e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
With the final discussion in #3689, this tries to improve the documentation to make clear the option to pass in
static_stability, as well as the relationship to various GEMPAK functions.Checklist