Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmake s3 support.wif #2741

Merged
merged 23 commits into from
Oct 2, 2023
Merged

Fix cmake s3 support.wif #2741

merged 23 commits into from
Oct 2, 2023

Commits on Aug 23, 2023

  1. Correct some logic so that S3 SDK is linked against if and when it is… 

    … found.
    @WardF
    WardF committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    dd69bb8 View commit details
    Browse the repository at this point in the history

  2. Remove diagnostic print statement.

    @WardF
    WardF committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0f7ebad View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Merge branch 'main' into fix-cmake-s3-support.wif

    @WardF
    WardF committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3637182 View commit details
    Browse the repository at this point in the history

  2. Revert an accidental change.

    @WardF
    WardF committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1eca1ad View commit details
    Browse the repository at this point in the history

  3. Modify how the aws-sdk-cpp libraries are detected using autotools. Co… 

    …mplicated by the fact that the 'official' method uses cmake.
    @WardF
    WardF committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    d90abc5 View commit details
    Browse the repository at this point in the history

  4. Correct the logic of when and how to link against amazon S3 AWS SDK l… 

    …ibraries.
    @WardF
    WardF committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    7333d09 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Adding a test which can be used to ensure that the AWSSDK which was d… 

    …iscovered at configure time is functional. Still need to wire it into autotools.
    @WardF
    WardF committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2f43247 View commit details
    Browse the repository at this point in the history

  2. Renamed pure-awssdk test to be more descriptive.

    @WardF
    WardF committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    718e485 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Add an explicit check for ctype.h to CMake so that S3_INTERNAL=TRUE w… 

    …orks.
    @WardF
    WardF committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ac4aade View commit details
    Browse the repository at this point in the history

  2. Added checks for -lssl and -lcrypto for cmake-based builds. We can't … 

    …assume they are available.
    @WardF
    WardF committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2e25cfc View commit details
    Browse the repository at this point in the history

  3. Tweak spacing in pure awssdk test.

    @WardF
    WardF committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    dd1ae95 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Disable 'force internal S3 on Windows'

    @WardF
    WardF committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    af07326 View commit details
    Browse the repository at this point in the history

  2. Add properties to pure awssdk for MSVC builds.

    @WardF
    WardF committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    c177ec0 View commit details
    Browse the repository at this point in the history

  3. Making test cases more verbose, turning off s3-based interoperability… 

    … tests TEMPORARILY.
    @WardF
    WardF committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    468e98f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-cmake-s3-support.wif' of github.com:WardF/netcdf-c … 

    …into fix-cmake-s3-support.wif
    @WardF
    WardF committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b87d921 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Turned off verbose debugging in test_s3sdk.c for now.

    @WardF
    WardF committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    22ecb88 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Add a missing include_directories invocation in CMakeLists.txt

    @WardF
    WardF committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    99e8ff3 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Turned on console logging/tracing.

    @WardF
    WardF committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    adfeec0 View commit details
    Browse the repository at this point in the history

  2. Remove explicit setting of request length, allow it to be computed au… 

    …tomatically.
    @WardF
    WardF committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    21d11a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Revert previous change; the issue appears to be correct, but the fix … 

    …appears to need to be different.
    @WardF
    WardF committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    973e5a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. A few tweaks for readability.

    @WardF
    WardF committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    543eeee View commit details
    Browse the repository at this point in the history

  2. Made some changes to spacing, also discovered an issue around specify… 

    …ing rpath on MacOSX when using configure.
    @WardF
    WardF committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    571fa06 View commit details
    Browse the repository at this point in the history

  3. Correct a couple of typos.

    @WardF
    WardF committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    b5bb7d8 View commit details
    Browse the repository at this point in the history