Now use H5Literate2() instead of H5Literate() when its available #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure the failures here have anything to do with my changes... |
|
The failures looked like something related to Github infrastructure/failure to fetch something from cache. I've triggered them to run again. |
|
Digging into it, I'm seeing an error that the cache can't be saved because another job is creating the cache. So it's nothing with this PR, but it feels like something is stuck in the pipes somewhere. I'll poke around some more. |
WardF
approved these changes
Aug 5, 2024
|
Thanks! |
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2714
Now use H5Literate2() when available, avoiding the compatibility macro.
In HDF5 releases prior to 1.12.0, H5Literate2() will not be present and the original H5Literate() will be used.