Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding zstd test #2965

Closed
wants to merge 22 commits into from
Closed

adding zstd test #2965

wants to merge 22 commits into from

Conversation

edwardhartnett
Copy link
Contributor

@edwardhartnett edwardhartnett commented Aug 7, 2024

Part of #2938
Fixes #2967

Adding some zstd testing.

Copy link
Collaborator

@DennisHeimbigner DennisHeimbigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not mess with H5PLappend and its related functions
until we come up with a more comprehensive and acceptable solution
to the plugin problem.

@edwardhartnett
Copy link
Contributor Author

Well let's come up with the comprehensive solution you refer to now. Because if we can eliminate the need for users to set the HDF5_PLUGIN_PATH, that would be a big help and no doubt save a lot of support requests.

What else do you think needs to be resolved?

@edwardhartnett
Copy link
Contributor Author

I will take this down and work on it a bit more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins should be installed by default when zstd is found by autotools, like the CMake build does
2 participants