Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address ordering issue with HTTP VFD, H5FDunregister #3013

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

WardF
Copy link
Member

@WardF WardF commented Sep 4, 2024

Based on the feedback on from @jhendersonHDF, I was able to eliminate in the error stack messages related to H5FDunregister, in my own environment (Ubuntu 22.04). I am testing this in other environments/compiler combinations, and I will integrate the PR @edwardhartnett put up to integrate a test for this issue, #3012, before final merge.

@WardF WardF self-assigned this Sep 4, 2024
@WardF
Copy link
Member Author

WardF commented Sep 4, 2024

This fixed the issue with HDF-DIAG messages being printed, but I am still seeing test failures in nc_test4/run_par_tests.sh on Ubuntu 24.04 using mpich and a self-built libhdf5 1.14.4, using LDFLAGS=-"Wl,-Bsymbolic-functions -flto=auto -Wl,-z,relro"


*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...ok.
*** Testing parallel IO for different hyperslab selections with MPI-IO (driver)...ok.
*** Testing parallel IO for extending variables with MPI-IO (driver)...ok.
*** Testing parallel IO for raw-data with MPIPOSIX-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...Sorry! Unexpected result, /home/vagrant/Desktop/netcdf-c/nc_test4/tst_parallel3.c, line: 284
Sorry! Unexpected result, /home/vagrant/Desktop/netcdf-c/nc_test4/tst_parallel3.c, line: 120

*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...
*** Testing more advanced parallel access.
*** Testing parallel IO for raw-data with MPI-IO (driver)...Sorry! Unexpected result, /home/vagrant/Desktop/netcdf-c/nc_test4/tst_parallel3.c, line: 284
Sorry! Unexpected result, /home/vagrant/Desktop/netcdf-c/nc_test4/tst_parallel3.c, line: 91

@WardF
Copy link
Member Author

WardF commented Sep 4, 2024

This also fails using the Ubuntu-provided libhdf5-mpich-dev package.

@WardF WardF mentioned this pull request Sep 4, 2024
@WardF WardF merged commit 382ffb8 into Unidata:main Sep 5, 2024
107 checks passed
@WardF WardF deleted the gh2990-http-vfd.wif branch September 5, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nc_create_par triggers HDF5 error stack message related to H5FDunregister
1 participant