Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add v3 #2

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Feat/add v3 #2

merged 4 commits into from
Jul 3, 2024

Conversation

gretzke
Copy link
Collaborator

@gretzke gretzke commented Jul 3, 2024

Pull Request

Description

Please include a summary of the change and which feature was implemented or which issue was fixed. Also, include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

Before deployment

  • 100% test and branch coverage
  • check slither for severe issues
  • fuzz and invariant tests (when applicable)
  • formal verification (when applicable)
  • deployment or upgrade scripts ready

After deployment

  • transfer ownership after deployments (when applicable)
  • complete upgrade (when applicable)
  • generate deployment/upgrade log files

Considerations

  • I have followed the contributing guidelines.
  • My code follows the style guidelines of this project and I have run forge fmt and prettier to ensure the code style is valid
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional context

Add any other context about the pull request here.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Forge code coverage:

File % Lines % Statements % Branches % Funcs
Total 100.00% (0/0) 100.00% (0/0) 100.00% (0/0) 100.00% (0/0)

@gretzke gretzke merged commit fbbd1e4 into dev Jul 3, 2024
3 checks passed
@gretzke gretzke deleted the feat/add-v3 branch July 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants