Update examples for new v3-sdk version #61

Florian-S-A-W · 2023-12-27T16:47:14Z

Update all examples to use the new v3-sdk version published by the Uniswap foundation.
Delete multicall example.

Feat/oracle

Advanced Examples

Remove unused functions and constants in range-order, update readme. Return actual target price of range order instead of user defined price from which order is created

Feat/advanced

Add get pool data via multicall code example

Remove unused Wallet, rename multicall provider

Update quoting example

Switch quoting example to quoteExactInput function

Feat/trading updated

…n-update Feat/release sdk version update

Import packages from foundation npm

socket-security · 2023-12-27T16:52:20Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/[email protected]	None	`0`	23.3 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	64.6 kB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem, unsafe	`+20`	11.8 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment, filesystem, unsafe	`+9`	10.8 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+5`	3.25 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment, filesystem	`+8`	4.61 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment, filesystem, unsafe	`+26`	12.1 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment, filesystem, unsafe	`+10`	11 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	1.89 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	1.89 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment Transitive: filesystem, unsafe	`+102`	15.3 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment Transitive: filesystem, unsafe	`+18`	12.6 MB	nicolo-ribaudo
npm/@babel/[email protected]	None	`+1`	275 kB	nicolo-ribaudo
npm/@babel/[email protected]	None	`0`	246 kB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+5`	8.69 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+9`	5.84 MB	nicolo-ribaudo
npm/@babel/[email protected]	Transitive: environment	`+2`	4.91 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`0`	2.41 MB	nicolo-ribaudo
npm/@babel/[email protected]	environment	`0`	2.41 MB	nicolo-ribaudo
npm/@jridgewell/[email protected]	None	`+2`	265 kB	jridgewell
npm/@types/[email protected]	Transitive: environment	`+2`	4.91 MB	types
npm/@types/[email protected]	None	`+2`	236 kB	types
npm/@types/[email protected]	None	`0`	185 kB	types
npm/@types/[email protected]	None	`0`	185 kB	types
npm/@types/[email protected]	None	`+7`	10.6 MB	types
npm/@types/[email protected]	None	`0`	3.51 MB	types
npm/@types/[email protected]	None	`0`	3.51 MB	types
npm/@types/[email protected]	None	`0`	3.51 MB	types
npm/@types/[email protected]	None	`+4`	1.63 MB	types
npm/@types/[email protected]	None	`0`	33.1 kB	types
npm/@types/[email protected]	None	`+3`	1.59 MB	types
npm/@types/[email protected]	None	`0`	365 kB	types
npm/@uniswap/[email protected]	environment, network Transitive: filesystem, shell	`+50`	24.2 MB	jsy1218
npm/@uniswap/[email protected]	None	`+3`	6.41 MB	emag3m
npm/@uniswapfoundation/[email protected]	None	`0`	83.2 kB	koraykoska
npm/@uniswapfoundation/[email protected]	None	`+1`	499 kB
npm/[email protected]	None	`0`	531 kB	marijn
npm/[email protected]	environment, filesystem	`+5`	4.49 MB	ai
npm/[email protected]	environment, filesystem	`+4`	4.48 MB	ai
npm/[email protected]	None	`0`	1.93 MB	caniuse-lite
npm/[email protected]	None	`0`	1.94 MB	caniuse-lite
npm/[email protected]	None	`0`	1.94 MB	caniuse-lite
npm/[email protected]	None	`0`	1.94 MB	caniuse-lite
npm/[email protected]	Transitive: environment, filesystem	`+6`	5.17 MB	zloirock
npm/[email protected]	Transitive: environment, filesystem	`+5`	5.17 MB	zloirock
npm/[email protected]	environment, filesystem Transitive: unsafe	`+23`	7.58 MB	eslintbot
npm/[email protected]	environment, filesystem	`+1`	3.05 MB	eslintbot
npm/[email protected]	network	`0`	28.6 kB	rubenverborgh
npm/[email protected]	None	`0`	186 kB	evilebottnawi
npm/[email protected]	environment, filesystem	`+1`	221 kB	ai
npm/[email protected]	environment, filesystem	`0`	197 kB	ai
npm/[email protected]	Transitive: eval	`+8`	173 kB	ljharb
npm/[email protected]	environment, eval	`+6`	3.23 MB	fabiosantoscode
npm/[email protected]	environment, eval	`0`	2.12 MB	fabiosantoscode
npm/[email protected]	None	`0`	73.1 kB	ethan_arrowood

View full report↗︎

Update V3 sdk version

Fix/release patch

…der-router Add deprecation notice to routing and swap-and-add-liquidity

socket-security · 2024-01-25T12:32:30Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@uniswap/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Florian-S-A-W · 2024-01-25T12:48:37Z

@SocketSecurity ignore npm/@uniswap/[email protected]

Florian-S-A-W · 2024-01-25T12:50:08Z

How does this bot not recognize 4.0.0 is newer than 3.3.0

mr-uniswap · 2024-01-25T18:13:06Z

@Florian-S-A-W Sorry about this, I'll look into why Socket is not recognizing version 4. Feel free to merge anyway.

mr-uniswap · 2024-01-25T18:16:58Z

v3-sdk/minting-position/package.json

@@ -6,8 +6,8 @@
    "@types/node": "^16.7.13",
    "@types/react": "^18.0.0",
    "@types/react-dom": "^18.0.0",
-    "@uniswap/sdk-core": "^3.1.0",
-    "@uniswap/v3-sdk": "^3.9.0",
+    "@uniswap/sdk-core": "npm:@uniswapfoundation/sdk-core@^5.0.0",


Note to self: this appears to be where the issue is

Referencing https://www.npmjs.com/package/@uniswapfoundation/v3-sdk

Update: This is not the issue

feross · 2024-01-25T18:31:52Z

I know this message doesn't make much sense, but the package @uniswap/[email protected] actually has been deprecated by the maintainer with the message "Use >3.3.0". You can see the same information displayed on the official npm package page: https://www.npmjs.com/package/@uniswap/v2-sdk/v/4.0.0

Is it possible to bump the package to @uniswap/[email protected] which is not deprecated?

mikolalysenko · 2024-01-25T18:44:08Z

v3-sdk/routing/yarn.lock

-  version "3.0.1"
-  resolved "https://registry.yarnpkg.com/@uniswap/v2-sdk/-/v2-sdk-3.0.1.tgz#690c484104c1debd1db56a236e5497def53d698b"
-  integrity sha512-eSpm2gjo2CZh9FACH5fq42str/oSNyWcDxB27o5k44bEew4sxb+pld4gGIf/byJndLBvArR9PtH8c0n/goNOTw==
+"@uniswap/v2-sdk@npm:@uniswapfoundation/v2-sdk@^4.0.0":


This is the line that is causing the GitHub bot to get confused. It should be loading @uniswapfoundation/v2-sdk not @uniswap/v2-sdk.

Sorry about this mistake.

Thanks @mikolalysenko. This should be the undeprecated package https://www.npmjs.com/package/@uniswapfoundation/v2-sdk

I'll update this package to a newer version.

Fix smart-order-router version in swap-and-add-liquidity example

Florian-S-A-W · 2024-01-26T19:56:02Z

The latest commit fixes this issue @mr-uniswap
@feross SocketSecurity doesn't seem to recognize package aliases - we use @uniswapfoundation/v2-sdk here as the package source for @uniswap/v2-sdk.

HossaWii

.github/workflows/lint-v3-sdk-collecting-fees.yaml

Florian-S-A-W · 2024-04-18T11:00:51Z

There are no changes to the lint that fails here.

jfbloom22 · 2024-05-09T11:35:34Z

v3-sdk/quoting/src/libs/constants.ts


 // Currencies and Tokens

 export const WETH_TOKEN = new Token(
-  SupportedChainId.MAINNET,
+  SUPPORTED_CHAINS[0],


Did you consider importing ChainId instead? Then you can do ChainId.MAINNET on line 13 and 21

Yeah that would make more sense here.

Florian-S-A-W and others added 30 commits June 4, 2023 12:31

Add naive tick visualization guide

e2ff0f1

Update graph to show custom tooltip, calculate virtual liquidity

57c7778

Calculate maximal extractable liquidity instead of virtual V2 liquidity

1161037

Improve formatting of Tooltip

96e9632

Cleanup tvl function in active liquidity

359470d

Add simple oracle example

f082741

Merge pull request #1 from Florian-S-A-W/feat/oracle

ca3e9c4

Feat/oracle

Add range order setup with Mock Market Maker

8ddd1a5

Mint, watch and withdraw range order

f8170ca

Update Readme

23e46b3

Update config and change lower tick configuration

7ef7f74

Update readme, config, small changes in MMM and React

4080dac

Merge pull request #3 from uniswapfoundation/feat/range-order

bf2d8fc

Advanced Examples

Clean up pool data dependencies and remove unused constants

1b7e598

Cleanup oracle, remove unused functions and constants

d08503e

Cleanup range-order

134d2be

Remove unused functions and constants in range-order, update readme. Return actual target price of range order instead of user defined price from which order is created

Merge pull request #4 from uniswapfoundation/feat/advanced

f5979e3

Feat/advanced

Add get pool data via multicall code example

afae74b

Merge pull request #5 from uniswapfoundation/feat/multicall-pool-data

490b4f6

Add get pool data via multicall code example

Remove unused Wallet from config and README

e9b2982

Merge pull request #6 from uniswapfoundation/feat/multicall-pool-data

89e2a97

Remove unused Wallet, rename multicall provider

Merge remote-tracking branch 'upstream/main'

44f96c6

Update quoting guide

08cf3c5

Merge pull request #7 from uniswapfoundation/feat/quoting_updated

dd91c2f

Update quoting example

Switch quoting example to quoteExactInput function

53764eb

Merge pull request #8 from uniswapfoundation/feat/quoting_updated

195c322

Switch quoting example to quoteExactInput function

Update dependencies

f1e4832

Update trading example for new sdk version

f85c43b

Merge pull request #9 from uniswapfoundation/feat/trading_updated

a20c5a9

Feat/trading updated

Use updated version of v3-sdk

ec12d63

Florian-S-A-W added 5 commits December 20, 2023 18:06

Update swap and add liquidity dependencies to v3-sdk release version

f522e4b

Update sor dependency in routing example

559578e

Merge pull request #20 from uniswapfoundation/feat/release-sdk-versio…

2b19b8a

…n-update Feat/release sdk version update

Import packages from foundation npm

cc14fc4

Merge pull request #21 from uniswapfoundation/feat/foundation-deps

ee6bd6a

Import packages from foundation npm

Florian-S-A-W mentioned this pull request Dec 27, 2023

feat: new docs for updated v3-sdk Uniswap/docs#648

Open

Florian-S-A-W and others added 8 commits January 6, 2024 19:34

Update sdk version

2a2a991

Merge pull request #22 from uniswapfoundation/feat/foundation-sdk

ba3833d

Update V3 sdk version

Improve UX of some examples

28bd5c4

Show mainnet rpc warning only if on mainnet environment

91e656e

Remove default fork url from range order

64c53fe

Merge pull request #23 from uniswapfoundation/fix/release-patch

4d2cf9a

Fix/release patch

Add deprecation notice to routing and swap-and-add-liquidity

db7bcac

Merge pull request #24 from uniswapfoundation/feat/deprecate-smart-or…

a335a78

…der-router Add deprecation notice to routing and swap-and-add-liquidity

mr-uniswap reviewed Jan 25, 2024

View reviewed changes

mikolalysenko reviewed Jan 25, 2024

View reviewed changes

Florian-S-A-W added 2 commits January 26, 2024 20:45

Fix smart-order-router version in swap-and-add-liquidity example

7bacc76

Merge pull request #25 from uniswapfoundation/fix/sor-version-fix

dc73396

Fix smart-order-router version in swap-and-add-liquidity example

HossaWii approved these changes Apr 18, 2024

View reviewed changes

jfbloom22 reviewed May 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update examples for new v3-sdk version #61

Update examples for new v3-sdk version #61

Florian-S-A-W commented Dec 27, 2023

socket-security bot commented Dec 27, 2023 •

edited

Loading

socket-security bot commented Jan 25, 2024 •

edited

Loading

Florian-S-A-W commented Jan 25, 2024

Florian-S-A-W commented Jan 25, 2024

mr-uniswap commented Jan 25, 2024

mr-uniswap Jan 25, 2024 •

edited

Loading

mr-uniswap Jan 25, 2024

mr-uniswap Jan 25, 2024

feross commented Jan 25, 2024 •

edited

Loading

mikolalysenko Jan 25, 2024

mr-uniswap Jan 25, 2024

Florian-S-A-W Jan 26, 2024

Florian-S-A-W commented Jan 26, 2024

HossaWii left a comment

Florian-S-A-W commented Apr 18, 2024

jfbloom22 May 9, 2024

Florian-S-A-W May 9, 2024

Update examples for new v3-sdk version #61

Are you sure you want to change the base?

Update examples for new v3-sdk version #61

Conversation

Florian-S-A-W commented Dec 27, 2023

socket-security bot commented Dec 27, 2023 • edited Loading

socket-security bot commented Jan 25, 2024 • edited Loading

Next steps

Florian-S-A-W commented Jan 25, 2024

Florian-S-A-W commented Jan 25, 2024

mr-uniswap commented Jan 25, 2024

mr-uniswap Jan 25, 2024 • edited Loading

Choose a reason for hiding this comment

mr-uniswap Jan 25, 2024

Choose a reason for hiding this comment

mr-uniswap Jan 25, 2024

Choose a reason for hiding this comment

feross commented Jan 25, 2024 • edited Loading

mikolalysenko Jan 25, 2024

Choose a reason for hiding this comment

mr-uniswap Jan 25, 2024

Choose a reason for hiding this comment

Florian-S-A-W Jan 26, 2024

Choose a reason for hiding this comment

Florian-S-A-W commented Jan 26, 2024

HossaWii left a comment

Choose a reason for hiding this comment

Florian-S-A-W commented Apr 18, 2024

jfbloom22 May 9, 2024

Choose a reason for hiding this comment

Florian-S-A-W May 9, 2024

Choose a reason for hiding this comment

socket-security bot commented Dec 27, 2023 •

edited

Loading

socket-security bot commented Jan 25, 2024 •

edited

Loading

mr-uniswap Jan 25, 2024 •

edited

Loading

feross commented Jan 25, 2024 •

edited

Loading