Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging #9

Merged
merged 5 commits into from
Oct 16, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/semgrep.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
- main
schedule:
# random HH:MM to avoid a load spike on GitHub Actions at 00:00
- cron: '35 11 * * *'
- cron: "35 11 * * *"
jobs:
semgrep:
name: semgrep/ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trufflehog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
path: ./
base: "${{ github.event.repository.default_branch }}"
head: HEAD
extra_args: --debug --only-verified
extra_args: --debug --only-verified

- name: Scan Results Status
if: steps.trufflehog.outcome == 'failure'
Expand Down
6 changes: 2 additions & 4 deletions script/Deploy.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ import {Counter} from 'src/Counter.sol';
contract Deploy is Script {
using stdJson for string;

function run() public returns (Counter counter) {
vm.startBroadcast(vm.envUint('PRIVATE_KEY'));
function run() public returns (Counter) {
uint256 initialNumber = 5;
counter = new Counter(initialNumber);
vm.stopBroadcast();
return new Counter(initialNumber);
}
}
1 change: 0 additions & 1 deletion test/Counter.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ contract DeploymentTest is Test {
Counter counter;

function setUp() public virtual {
vm.setEnv('PRIVATE_KEY', vm.toString(makeAccount('DEPLOYER').key));
counter = new Deploy().run();
}

Expand Down
Loading