Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Add @ethersproject/solidity, tiny-invariant, jsbi explicit dependencies #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rubilmax
Copy link

@Rubilmax Rubilmax commented Nov 2, 2022

Issue

  • jsbi@^3.1.4 dependency is used in the package without being defined as an explicit dependency in package.json
  • @ethersproject/solidity@^5.0.9 dependency is used in the package without being defined as an explicit dependency in package.json
  • tiny-invariant@^1.1.0 dependency is used in the package without being defined as an explicit dependency in package.json

This impacts developers using this package as dependency resolvers (such as npm or yarn) won't automatically install missing dependencies, or will install it with incorrect (and thus perhaps incompatible) versions

Fix

  • This PR adds the missing dependencies to package.json without impacting the current state of yarn.lock

@Rubilmax Rubilmax changed the title Add jsbi@^3.1.4 dependency Add @ethersproject/solidity@^5.0.4, tiny-invariant@^1.1.0, jsbi@^3.1.4 dependency Nov 2, 2022
@Rubilmax Rubilmax changed the title Add @ethersproject/solidity@^5.0.4, tiny-invariant@^1.1.0, jsbi@^3.1.4 dependency Add @ethersproject/solidity@^5.0.4, tiny-invariant@^1.1.0, jsbi@^3.1.4 explicit dependencies Nov 2, 2022
@Rubilmax Rubilmax changed the title Add @ethersproject/solidity@^5.0.4, tiny-invariant@^1.1.0, jsbi@^3.1.4 explicit dependencies Add @ethersproject/solidity, tiny-invariant, jsbi explicit dependencies Nov 2, 2022
@napalmpapalam
Copy link

I have this issue too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants