Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

chore: update core deps #47

Merged
merged 2 commits into from
Aug 28, 2023
Merged

chore: update core deps #47

merged 2 commits into from
Aug 28, 2023

Conversation

grabbou
Copy link
Contributor

@grabbou grabbou commented Aug 22, 2023

Per Uniswap/interface#6974 (comment), we're relaxing dependency on the core to use semver. This will make it easier to update the codebase as a whole and avoid duplicate entries in the interface.

Since @uniswap/swap-router-contracts is the one that consumes core directly, dependency on it its being relaxed too.

@grabbou grabbou requested a review from zzmp August 22, 2023 18:22
Copy link

@zzmp zzmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - please make sure to run npx yarn-deduplicate && yarn install again to weed out any duplicates that are left.

@grabbou
Copy link
Contributor Author

grabbou commented Aug 24, 2023

@zzmp do we run yarn-deduplicate as a standard part of release pipeline for libraries? AFAIK for libraries this is not that relevant, we're no shipping them along the package and usually prefer testing against latest environment.

@zzmp
Copy link

zzmp commented Aug 24, 2023

if the point of this is to avoid duplicate entries, you should still update the lockfile to do so. it also makes it more obvious if something is defined incorrectly.

@grabbou
Copy link
Contributor Author

grabbou commented Aug 28, 2023

if the point of this is to avoid duplicate entries, you should still update the lockfile to do so

You are right, but the problem happens in the parent package that consumes all different Uniswap packages, not here in development (we will run dedupe in interface when all packages are upgraded). Running that is a good practice, but is separate from this PR. I've run it anyway, will default to running in the future then too.

@grabbou grabbou merged commit 70e23a3 into main Aug 28, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants