fix(universal-router-sdk): handles all ETH/WETH transitions #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilz
requested review from
jsy1218,
dannythedawger,
cgkol and
a team
as code owners
This reverts commit 1de6365.
ewilz
changed the title
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (10/15/24)1 reviewer was added and 1 assignee was added to this PR based on 's automation. |
jsy1218
reviewed
Oct 15, 2024
jsy1218
reviewed
Oct 15, 2024
jsy1218
reviewed
Oct 15, 2024
jsy1218
approved these changes
Oct 15, 2024
jsy1218
approved these changes
Oct 18, 2024
hensha256
reviewed
Oct 30, 2024
| @@ -65,8 +65,7 @@ export class UniswapTrade implements Command { | |||
|
|
|||
| constructor(public trade: RouterTrade<Currency, Currency, TradeType>, public options: SwapOptions) { | |||
| if (!!options.fee && !!options.flatFee) throw new Error('Only one fee option permitted') | |||
| if (this.inputRequiresWrap) this.payerIsUser = false | |||
| else if (this.options.useRouterBalance) this.payerIsUser = false | |||
| if (this.inputRequiresWrap || this.inputRequiresUnwrap || this.options.useRouterBalance) this.payerIsUser = false | |||
There was a problem hiding this comment.
could just be done using a this.payerIsUser = () ? false : true might be clearer?
There was a problem hiding this comment.
linting on this is ugly IMO but could be done...
sdks/universal-router-sdk/test/forge/SwapERC20CallParameters.t.sol
Outdated
Show resolved
Hide resolved
sdks/universal-router-sdk/test/forge/SwapERC20CallParameters.t.sol
Outdated
Show resolved
Hide resolved
sdks/universal-router-sdk/test/forge/SwapERC20CallParameters.t.sol
Outdated
Show resolved
Hide resolved
hensha256
approved these changes
Nov 14, 2024
hensha256
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now enables: