fix(v4-sdk): swap function accepts pools with all hooks except swap hooks #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
reviewed
Nov 8, 2024
sdks/v4-sdk/src/entities/pool.ts
Outdated
| return this.hooks === ADDRESS_ZERO | ||
| private hookHasSwapPermissions(): boolean { | ||
| return ( | ||
| Hook.hasPermission(this.hooks, HookOptions.BeforeSwap) || Hook.hasPermission(this.hooks, HookOptions.AfterSwap) |
There was a problem hiding this comment.
do we need to check BeforeSwapReturnsDelta and AfterSwapReturnsDelta?
There was a problem hiding this comment.
No, because these options only get hit if either beforeSwap or AfterSwap are true. (before/afterSwapReturnsDelta cannot be true if beforeSwap or afterSwap are false)
https://github.com/Uniswap/v4-core/blob/main/src/libraries/Hooks.sol#L265
There was a problem hiding this comment.
I can leave a code comment
jsy1218
approved these changes
Nov 8, 2024
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (11/13/24)1 assignee was added and 1 reviewer was added to this PR based on 's automation. |
jsy1218
approved these changes
Nov 14, 2024
jsy1218
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.