Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uniswapx-sdk): DutchV3 cosigner digest #211

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

codyborn
Copy link
Contributor

@codyborn codyborn commented Dec 2, 2024

Description

Updating the contract bytecode and cosigner digest generation to the latest.

How Has This Been Tested?

Local tests

Are there any breaking changes?

No

@codyborn codyborn requested review from jsy1218 and a team as code owners December 2, 2024 13:45
Copy link
Member

@ConjunctiveNormalForm ConjunctiveNormalForm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Do we want to have a test here given that we are handrolling the fields here

Copy link

graphite-app bot commented Dec 2, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/02/24)

1 reviewer was added and 1 assignee was added to this PR based on 's automation.

@alanhwu
Copy link
Contributor

alanhwu commented Dec 2, 2024

We have an integration test to test changes like this, it was what made us realize the abi needed updating

@alanhwu alanhwu merged commit 609bf3f into main Dec 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants