Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(universal-router-sdk): update universal router and v4 dependency version #219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dianakocsis
Copy link
Contributor

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

Copy link

graphite-app bot commented Dec 16, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (12/16/24)

1 reviewer was added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218
Copy link
Member

jsy1218 commented Dec 16, 2024

UR is re-deployed on Sepolia, Base Sepolia, Arb Sepolia, and Unichain Sepolia right? Do we need to update UR v2.0 address in this file

export const CHAIN_CONFIGS: { [key: number]: ChainConfig } = {
, in this same PR?

@jsy1218
Copy link
Member

jsy1218 commented Dec 16, 2024

Also Im thinking whether we should merge #217 first. It seems like merging ur-sdk first might not break, but it's still a good practice to merge sdk-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants