Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v3-sdk): annotate FACTORY_ADDRESS as deprecated #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jul 3, 2024

Description

[Summary of the change, motivation, and context]
Issue raised in #57, and addressed in this PR

How Has This Been Tested?

It's a comment deprecate annotation, so no functional change.

Are there any breaking changes?

No

(Optional) Feedback Focus

No

(Optional) Follow Ups

N/A

Copy link
Member Author

jsy1218 commented Jul 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review July 3, 2024 12:56
@jsy1218 jsy1218 requested a review from a team as a code owner July 3, 2024 12:56
<component name="AutoImportSettings">
<option name="autoReloadType" value="SELECTIVE" />
</component>
<component name="ChangeListManager">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being added?

@graphite-app graphite-app bot requested a review from a team July 3, 2024 13:04
Copy link

graphite-app bot commented Jul 3, 2024

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (07/03/24)

2 reviewers were added and 1 assignee was added to this PR based on 's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants